chore(parser): deprecate AlbMultiValueHeadersSchema
#3523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
parser
|
leandrodamascena
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR marks as deprecated the
AlbMultiValueHeadersSchemaand standardizes the tests for this category of schema.The
AlbMultiValueHeadersSchemais marked as deprecated to standardize with the Python version of Powertools for AWS Lambda (Python). For ALB the single-value version ofheadersandqueryStringParametersand the multi-value ones are mutually exclusive, so we can just aggregate the four properties in the regularAlbSchemaand mark them all as.optional()to achieve the same result.This reduces the cognitive load for customers and avoids them having to use two different schemas if they have different ALB configurations handled by functions sharing the same code.
Additionally the PR refactors and standardizes the Parser helpers tests.
Issue number: closes #3522
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.